[PATCH] D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 02:59:26 PDT 2019


jhenderson added a comment.

In D63084#1541260 <https://reviews.llvm.org/D63084#1541260>, @MaskRay wrote:

> D62072 <https://reviews.llvm.org/D62072> seems to promote lowercasing the first letter in error messages.


Yes, I agree with that, although it's debatable as to whether these are the same, since they aren't independent error messages printed on stderr, so the guidelines might not be the same. I don't really know though!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63084/new/

https://reviews.llvm.org/D63084





More information about the llvm-commits mailing list