[PATCH] D63191: [lld][ELF] Check length of subsection in .ARM.attributes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 02:27:18 PDT 2019


MaskRay added inline comments.


================
Comment at: tools/lld/test/ELF/bad-arm-attributes2.s:2
+# RUN: llvm-mc -filetype=obj -triple=arm-unknown-linux %s -o %t
+# RUN: ld.lld %t -o %tout 2>&1 | FileCheck %s
+
----------------
MaskRay wrote:
> `%tout` -> `/dev/null`
Oh, wait.

```
// ELF/InputFiles.cpp

    Attributes.Parse(Contents, /*isLittle*/ Config->EKind == ELF32LEKind);
```

`Parse` doesn't return an error? That may be something that should be improved later..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63191/new/

https://reviews.llvm.org/D63191





More information about the llvm-commits mailing list