[PATCH] D62938: [SLP] Forbid to vectorize bundles with same opcode but different IR flags

Thu Jun 13 00:36:54 PDT 2019

RKSimon added a comment.

In D62938#1540822 <https://reviews.llvm.org/D62938#1540822>, @dtemirbulatov wrote:

> In D62938#1533142 <https://reviews.llvm.org/D62938#1533142>, @RKSimon wrote:
>
> > In D62938#1532286 <https://reviews.llvm.org/D62938#1532286>, @lebedev.ri wrote:
> >
> > > Please can you add a better explanation of the problem to the description of the patch?
> > >  I'm not sure what the problem is, you are allowed to drop `nuw`/`nsw` flags: https://rise4fun.com/Alive/plNm
> > >  So the new vectorized binop should simply take the smallest common subset of flags, which likely most often means no flags.
> >
> >
> > @dtemirbulatov It might be worth adding tests that check that we do retain the common subset?
>
>
> done with Committed revision 363218.

Thanks @dtemirbulatov !

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62938/new/

https://reviews.llvm.org/D62938