[PATCH] D57779: [SLP] Add support for throttling.

Wed Jun 12 11:26:24 PDT 2019

dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.

================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3443
+void BoUpSLP::treeTraversal(SmallVectorImpl<unsigned> &Leaves,
+                            SmallVectorImpl<unsigned> &Branches) const {
+  SmallVector<unsigned, 16> Worklist;
----------------
vporpo wrote:
> You don't seem to be using the order of the entries in `branches` apart from checking is_contained() a couple of times. Isn't it better to add a member variable in TreeEntry for this instead?
> 
> Also I don't understand what is considered a `branch`. Is it any non-leaf node in the graph? Could you add some comment about it.
>Also I don't understand what is considered a branch. Is it any non-leaf node in the graph? Could you add some comment about it.
I think it is a node that uses more than one non-gathering node, or in other words, it has more than one non-gathering children.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779