[PATCH] D57779: [SLP] Add support for throttling.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 08:23:42 PDT 2019


dtemirbulatov marked an inline comment as done.
dtemirbulatov added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3448
+  Worklist.push_back(0);
+  // Does a BFS on non-gathering nodes of SLP graph and since the graph might
+  // have cycles we have to mark each visited node to process such tree.
----------------
vporpo wrote:
> Why is this a BFS ? Can't you visit the entries in the order they are pushed in VectorizableTree and collect the `Leaves` ?
yes, It should work, we have VectorizableTree order, we don't have to build our own to process cycles. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779





More information about the llvm-commits mailing list