[PATCH] D63184: [llvm-objcopy] Recognize the output file format other than ELF

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 04:14:29 PDT 2019


seiya added a comment.

In D63184#1539487 <https://reviews.llvm.org/D63184#1539487>, @jhenderson wrote:

> @seiya, it looks like what you've observed in the tests is https://bugs.llvm.org/show_bug.cgi?id=42171. Can you confirm, and if so update the bug accordingly?
>
> I feel like there might be three different patches here, rather than one big one. The first one is the bug fix (with corresponding test changes), the second is the sparc format issue, and the third is the work your title suggests this patch should be doing (i.e. changing the types). Please could you split it up, as it will make it easier to review each change separately.


Thank you. I missed that. That bug is what I want to fix this patch. I'll split this into separate patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63184/new/

https://reviews.llvm.org/D63184





More information about the llvm-commits mailing list