[PATCH] D63158: StackProtector: Use PointerMayBeCaptured

Tue Jun 11 21:24:40 PDT 2019

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

This looks good to me (LGTM). Give it a bit of time though for people familiar with this code to take a look if they want.

================
Comment at: test/CodeGen/X86/stack-protector.ll:4091
+  store i32 1, i32* %1, align 4
+  %3 = load i32, i32* %1, align 4
   %4 = mul nsw i32 %3, 42
----------------
jdoerfert wrote:
> arsenm wrote:
> > jdoerfert wrote:
> > > Was the problem we assume volatile stores cause the addrs to escape (=be captured)?
> > > If so, can we add a comment, maybe even a negative test (with the volatile accesses)?
> > I think the interpretation of volatile capturing the address is absurd, but I don't care enough to fight that battle. The volatiles were irrelevant for the test here
> Fair point.
At least the change is now "documented" in this review ;)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63158/new/

https://reviews.llvm.org/D63158