[PATCH] D63163: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 13:28:10 PDT 2019


arsenm added a comment.

I thought PeepholeOptimizer took care of this sort of thing?



================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:3033-3034
+    I.getOperand(2).setReg(LHSDef->getOperand(2).getReg());
+    return true;
+  } else if (IsCMN(RHSDef, CC)) {
+    // Same idea here, but with the RHS of the compare instead:
----------------
No else after return


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63163/new/

https://reviews.llvm.org/D63163





More information about the llvm-commits mailing list