[PATCH] D62904: [DebugInfo] Honour variable fragments in LiveDebugValues

Tue Jun 11 09:24:52 PDT 2019

jmorse marked 3 inline comments as done.
jmorse added a comment.

In D62904#1537110 <https://reviews.llvm.org/D62904#1537110>, @aprantl wrote:

> Please note that SROA is not the only producer of DW_OP_LLVM_fragments. The Swift frontend, for example, can produce fragments from the point where LLVM IR is generated long before LLVM's SROA is invoked. If a condition is not enforced by the Verifier it is not generally safe to rely on it because LLVM IR is generated by many producers, not just Clang.

Cool, I've implemented the alternative of having non-fragmented DBG_VALUEs overlap all fragmented ones, and added an additional function to the tests to check that those overlaps are recognised.

I feel like this should be rejected by the verifier, but I'm not confident enough to add such a check, and it's not a great burden to support anyway.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62904/new/

https://reviews.llvm.org/D62904