[PATCH] D63043: [ELF][PPC] Simplify {read,write}FromHalf16

Tue Jun 11 08:34:11 PDT 2019

sfertile added a comment.

In D63043#1538015 <https://reviews.llvm.org/D63043#1538015>, @MaskRay wrote:

> @sfertile Sorry but I can't find commit 729111cf1824159bb4dd331cab8a829eab30313f or f49f58527a6d8147524d8d6f2eb1feb70f856292 in either llvm/llvm-project (git monorepo) or llvm-mirror/lld (git multirepo). Do you have the revision numbers, e.g. r362867 (or rL362867 <https://reviews.llvm.org/rL362867> rLLD362867 <https://reviews.llvm.org/rLLD362867>; the latters give a clickable link on Phabricator)

Sorry I'm not sure where I grabbed those hashes from. The commits I pulled were https://reviews.llvm.org/rLLD362497 and https://reviews.llvm.org/rLLD361830. I verified the link failure on a local  machine, and then pulling those 2 commits and rebuilding fixed the problem. I'm not sure there is a problem with your commits per se, rather it seemed we are garbage collecting a section that is referenced by toc relocations.

In D63043#1537973 <https://reviews.llvm.org/D63043#1537973>, @MaskRay wrote:

> > Can you please address that before committing PPC64 changes like this. I don't understand why you would consider committing more PowerPC64 changes when the bot is in this state, rather then fixing it first.
>
> @sfertile @anil9 I haven't received any email from ppc64le-lld-multistage-test since May 23. I am sorry I missed Anil's earlier email on rL361830 <https://reviews.llvm.org/rL361830>.
>  @sfertile I find you reverted rL361830 <https://reviews.llvm.org/rL361830> and D62840 <https://reviews.llvm.org/D62840> then restored them. I can't find the explanation why you did that. Sorry if I missed them.

There seems to be some confusion all around, and I am sorry for that. I can see that Anils first message was before you pulled and updated your patch and we never followed up with you after your reland failed to fix the PowerPC build bot. Either way reverting those 2 patches is **needed** to get the bot back to green. Once they are pulled we can investigate what the underlying issue is. I'm reaching out to the current build bot monitor right now to get you the reproducer and so they can check if gold/bfd have a similar issue. (FWIW I checked the day I reverted the patches and there were no issues building with llvm and linking with gold).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63043/new/

https://reviews.llvm.org/D63043