[PATCH] D63132: [ELF][RISCV] Set st_shndx of __global_pointer$ to 1 if .sdata does not exist

Rich Felker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 07:59:12 PDT 2019


dalias added a comment.

I don't immediately see any problem with adding a dummy `.sdata`, though I think the linker should probably also be able to do this. defining a dummy `__global_pointer` with `SHN_ABS` makes no sense. The bfd linker doing this looks like a bug to me, and the bfd linker failing to produce an error when linking it looks like another bug.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63132/new/

https://reviews.llvm.org/D63132





More information about the llvm-commits mailing list