[PATCH] D63137: [yaml2obj] - Allow setting the custom Address for .strtab

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

LGTM, with one nit.



================
Comment at: test/tools/yaml2obj/implicit-sections-addr.yaml:5
+## Check yaml2obj does not ignore the address of the
+## explicitly listed .dynstr,.dynsym,.strtab
+## and .symtab sections.
----------------
Please add spaces after each ','.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:492
 
-  // If .dynstr section is explicitly described in the YAML
+  // If section is explicitly described in the YAML
   // then we want to use its section address.
----------------
If the section


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63137/new/

https://reviews.llvm.org/D63137