[PATCH] D60261: Change semantics of fadd/fmul vector reductions.

Tue Jun 11 07:37:22 PDT 2019

jhenderson added a comment.

In D60261#1538124 <https://reviews.llvm.org/D60261#1538124>, @sdesmalen wrote:

> In D60261#1538016 <https://reviews.llvm.org/D60261#1538016>, @jhenderson wrote:
>
> > It looks like the documentation change may have broken the sphinx doc job (though I'm not certain it was this change, but the error comes from one of the lines this file touched): http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/32236
>
>
> Thanks for pointing out, for some reason I did not get an automated email about this failure.
>
> I wonder if the `0.0` fp literal is causing the error, although I can't reproduce this locally (maybe due to different version of sphinx?). Probably the simplest fix to get buildbot passing again is to replace the `..code-block:: llvm` with `::`.
>
> (Note that the LangRef <https://www.llvm.org/docs/LangRef.html#llvm-experimental-vector-reduce-v2-fadd-intrinsic> on llvm.org is correctly updated)

Sounds good, although I'm not really up to speed with the sphinx system yet, so I can't say for sure that it will work!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60261/new/

https://reviews.llvm.org/D60261