[PATCH] D63116: Let writeWindowsResourceCOFF() take a TimeStamp parameter

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 04:31:50 PDT 2019


ruiu added a comment.

LGTM



================
Comment at: llvm/trunk/tools/llvm-cvtres/llvm-cvtres.cpp:94
+  if (Now < 0 || !isUInt<32>(Now))
+    return UINT32_MAX;
+  return static_cast<uint32_t>(Now);
----------------
Can this happen? Is this for the year 2038 problem?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63116/new/

https://reviews.llvm.org/D63116





More information about the llvm-commits mailing list