[PATCH] D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:376
+void warn(const Twine &Message) {
   WithColor::warning(errs(), ToolName) << Message << "\n";
 }
----------------
grimar wrote:
> I guess you need to keep `errs().flush()`.
I am not sure though. It seems should be better for debugging to keep it, i.e. I think this `flush`
allows to see a warning in the console output as soon it appears, what can probably be useful sometimes.
But I am not sure it is an important bit.

At the same time it seems that in `error(Twine Message)` above it is used before `exit(1)` to
flush the messages before application termination. But it is not used in `void report_error(StringRef File, Twine Message)` below.
It can be a bug probably.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62462/new/

https://reviews.llvm.org/D62462