[PATCH] D63121: [ELF] Make the rule to create relative relocations in a writable section stricter

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

This looks good to me. However, I think the name SymbolicRel does not make it immediately obvious to me it should be used for. Maybe add a comment to the member?



================
Comment at: ELF/Target.h:98
   RelType IRelativeRel;
+  RelType SymbolicRel;
   RelType TlsDescRel;
----------------
Maybe something like 'AbsPtrRel'? To me symbolic does not necessarily imply a elf_addr size relocation against a symbol.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63121/new/

https://reviews.llvm.org/D63121