[PATCH] D63120: Share /machine: handling code with llvm-cvtres too

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 20:42:58 PDT 2019


thakis created this revision.
thakis added a reviewer: pcc.
Herald added subscribers: hiraditya, mgorny.
Herald added a project: LLVM.

r363016 let lld-link and llvm-lib share the /machine: parsing code.
This lets llvm-cvtres share it as well.

Making llvm-cvtres depend on llvm-lib seemed a bit strange (it doesn't
need llvm-lib's dependencies on BinaryFormat and BitReader) and I
couldn't find a good place to put this code, so this adds a new tiny
library ToolDrivers/MachineFlag to house the shared code.


https://reviews.llvm.org/D63120

Files:
  lld/COFF/CMakeLists.txt
  lld/COFF/Driver.cpp
  lld/COFF/SymbolTable.cpp
  llvm/include/llvm/ToolDrivers/MachineFlag/MachineFlag.h
  llvm/include/llvm/ToolDrivers/llvm-lib/LibDriver.h
  llvm/lib/ToolDrivers/CMakeLists.txt
  llvm/lib/ToolDrivers/MachineFlag/CMakeLists.txt
  llvm/lib/ToolDrivers/MachineFlag/LLVMBuild.txt
  llvm/lib/ToolDrivers/MachineFlag/MachineFlag.cpp
  llvm/lib/ToolDrivers/llvm-lib/CMakeLists.txt
  llvm/lib/ToolDrivers/llvm-lib/LLVMBuild.txt
  llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp
  llvm/tools/llvm-cvtres/CMakeLists.txt
  llvm/tools/llvm-cvtres/LLVMBuild.txt
  llvm/tools/llvm-cvtres/llvm-cvtres.cpp
  llvm/utils/gn/secondary/lld/COFF/BUILD.gn
  llvm/utils/gn/secondary/llvm/lib/ToolDrivers/MachineFlag/BUILD.gn
  llvm/utils/gn/secondary/llvm/lib/ToolDrivers/llvm-lib/BUILD.gn
  llvm/utils/gn/secondary/llvm/tools/llvm-cvtres/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63120.203969.patch
Type: text/x-patch
Size: 13323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190611/029cee87/attachment.bin>


More information about the llvm-commits mailing list