[PATCH] D62939: Strengthen LFTR's ability to replace IVs

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 12:58:03 PDT 2019


reames updated this revision to Diff 203879.
reames added a comment.

Rebase on top of newly added tests.

After staring at the test diffs, I think we may have to recombine this back into D62936 <https://reviews.llvm.org/D62936>.  The problem is that by being willing to switch IVs for pointers (correctly now), we *also* expose more pre-to-post conversion opportunities on the new IVs.  So, despite getting the logic about dead IVs right, we're still miscompiling these in the end.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62939/new/

https://reviews.llvm.org/D62939

Files:
  lib/Transforms/Scalar/IndVarSimplify.cpp
  test/Transforms/IndVarSimplify/2011-11-01-lftrptr.ll
  test/Transforms/IndVarSimplify/lftr-dead-ivs.ll
  test/Transforms/IndVarSimplify/lftr-reuse.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62939.203879.patch
Type: text/x-patch
Size: 13660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190610/6f27a946/attachment.bin>


More information about the llvm-commits mailing list