[llvm] r362964 - [llvm-mca] Enable bottleneck analysis when flag -all-views is specified.

[Andrea Di Biagio via llvm-commits]

Author: adibiagio
Date: Mon Jun 10 09:56:25 2019
New Revision: 362964

URL: http://llvm.org/viewvc/llvm-project?rev=362964&view=rev
Log:
[llvm-mca] Enable bottleneck analysis when flag -all-views is specified.

Bottleneck Analysis is one of the many views available in llvm-mca. Therefore,
it should be enabled when flag -all-views is passed in input to the tool.

Modified:
    llvm/trunk/test/tools/llvm-mca/X86/BtVer2/bottleneck-hints-none.s
    llvm/trunk/test/tools/llvm-mca/X86/option-all-views-1.s
    llvm/trunk/test/tools/llvm-mca/X86/option-all-views-2.s
    llvm/trunk/test/tools/llvm-mca/X86/option-no-stats-1.s
    llvm/trunk/tools/llvm-mca/llvm-mca.cpp

Modified: llvm/trunk/test/tools/llvm-mca/X86/BtVer2/bottleneck-hints-none.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/bottleneck-hints-none.s?rev=362964&r1=362963&r2=362964&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/BtVer2/bottleneck-hints-none.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/BtVer2/bottleneck-hints-none.s Mon Jun 10 09:56:25 2019
@@ -1,5 +1,5 @@
 # NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py
-# RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2 -bottleneck-analysis -all-views=false -summary-view -iterations 1 < %s | FileCheck %s -implicit-check-not 'Cycles with backend pressure increase'
+# RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2 -all-views=false -summary-view -bottleneck-analysis -iterations 1 < %s | FileCheck %s -implicit-check-not 'Cycles with backend pressure increase'
 
 add %eax, %ebx
 

Modified: llvm/trunk/test/tools/llvm-mca/X86/option-all-views-1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/option-all-views-1.s?rev=362964&r1=362963&r2=362964&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/option-all-views-1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/option-all-views-1.s Mon Jun 10 09:56:25 2019
@@ -18,6 +18,13 @@ add %eax, %eax
 # DEFAULTREPORT-NEXT: IPC:               0.97
 # DEFAULTREPORT-NEXT: Block RThroughput: 0.5
 
+# FULLREPORT:         Cycles with backend pressure increase [ 76.70% ]
+# FULLREPORT-NEXT:    Throughput Bottlenecks:
+# FULLREPORT-NEXT:      Resource Pressure       [ 0.00% ]
+# FULLREPORT-NEXT:      Data Dependencies:      [ 76.70% ]
+# FULLREPORT-NEXT:      - Register Dependencies [ 76.70% ]
+# FULLREPORT-NEXT:      - Memory Dependencies   [ 0.00% ]
+
 # DEFAULTREPORT:      Instruction Info:
 # DEFAULTREPORT-NEXT: [1]: #uOps
 # DEFAULTREPORT-NEXT: [2]: Latency

Modified: llvm/trunk/test/tools/llvm-mca/X86/option-all-views-2.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/option-all-views-2.s?rev=362964&r1=362963&r2=362964&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/option-all-views-2.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/option-all-views-2.s Mon Jun 10 09:56:25 2019
@@ -17,6 +17,13 @@ add %eax, %eax
 # ALL-NEXT:        IPC:               0.97
 # ALL-NEXT:        Block RThroughput: 0.5
 
+# ALL:             Cycles with backend pressure increase [ 76.70% ]
+# ALL-NEXT:        Throughput Bottlenecks:
+# ALL-NEXT:          Resource Pressure       [ 0.00% ]
+# ALL-NEXT:          Data Dependencies:      [ 76.70% ]
+# ALL-NEXT:          - Register Dependencies [ 76.70% ]
+# ALL-NEXT:          - Memory Dependencies   [ 0.00% ]
+
 # ALL:             Instruction Info:
 # ALL-NEXT:        [1]: #uOps
 # ALL-NEXT:        [2]: Latency

Modified: llvm/trunk/test/tools/llvm-mca/X86/option-no-stats-1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/option-no-stats-1.s?rev=362964&r1=362963&r2=362964&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/option-no-stats-1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/option-no-stats-1.s Mon Jun 10 09:56:25 2019
@@ -15,6 +15,13 @@ add %edi, %eax
 # CHECK-NEXT: IPC:               0.97
 # CHECK-NEXT: Block RThroughput: 0.5
 
+# CHECK:      Cycles with backend pressure increase [ 76.70% ]
+# CHECK-NEXT: Throughput Bottlenecks:
+# CHECK-NEXT:   Resource Pressure       [ 0.00% ]
+# CHECK-NEXT:   Data Dependencies:      [ 76.70% ]
+# CHECK-NEXT:   - Register Dependencies [ 76.70% ]
+# CHECK-NEXT:   - Memory Dependencies   [ 0.00% ]
+
 # CHECK:      Instruction Info:
 # CHECK-NEXT: [1]: #uOps
 # CHECK-NEXT: [2]: Latency

Modified: llvm/trunk/tools/llvm-mca/llvm-mca.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/llvm-mca.cpp?rev=362964&r1=362963&r2=362964&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/llvm-mca.cpp (original)
+++ llvm/trunk/tools/llvm-mca/llvm-mca.cpp Mon Jun 10 09:56:25 2019
@@ -237,6 +237,7 @@ static void processViewOptions() {
 
   if (EnableAllViews.getNumOccurrences()) {
     processOptionImpl(PrintSummaryView, EnableAllViews);
+    processOptionImpl(EnableBottleneckAnalysis, EnableAllViews);
     processOptionImpl(PrintResourcePressureView, EnableAllViews);
     processOptionImpl(PrintTimelineView, EnableAllViews);
     processOptionImpl(PrintInstructionInfoView, EnableAllViews);