[PATCH] D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 07:36:34 PDT 2019


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM.



================
Comment at: llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp:634
     case ARM::t2CPS1p:
+    case ARM::t2CSEL:
+    case ARM::t2CSINC:
----------------
I don't see any tests that cover this.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:286
+  }
+  case ARM::fixup_bfl_target: {
+    int64_t Offset = int64_t(Value) - 4;
----------------
Another refactoring nit...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62667/new/

https://reviews.llvm.org/D62667





More information about the llvm-commits mailing list