[PATCH] D63075: [TargetLowering] Add MachineMemOperand::Flags to allowsMemoryAccess tests (PR42123)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 05:37:37 PDT 2019


RKSimon created this revision.
RKSimon added reviewers: niravd, efriedma, craig.topper, t.p.northover, atanasyan, uweigand, jonpa, kparzysz, arsenm, hfinkel, tlively, wristow.
Herald added subscribers: jsji, jrtc27, kbarton, aheejin, jgravelle-google, sbc100, javed.absar, nhaehnle, wdng, jvesely, nemanjai, sdardis, dschuff.
Herald added a project: LLVM.

As discussed on D62910 <https://reviews.llvm.org/D62910>, we need to check whether particular types of memory access are allowed, not just their alignment/address-space.

This NFC patch adds a MachineMemOperand::Flags argument to allowsMemoryAccess and allowsMisalignedMemoryAccesses, and wires up calls to pass the relevant flags to them.

If people are happy with this approach I can then update X86TargetLowering::allowsMisalignedMemoryAccesses to handle misaligned NT load/stores.


Repository:
  rL LLVM

https://reviews.llvm.org/D63075

Files:
  include/llvm/CodeGen/BasicTTIImpl.h
  include/llvm/CodeGen/TargetLowering.h
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  lib/CodeGen/TargetLoweringBase.cpp
  lib/Target/AArch64/AArch64ISelLowering.cpp
  lib/Target/AArch64/AArch64ISelLowering.h
  lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  lib/Target/AMDGPU/R600ISelLowering.cpp
  lib/Target/AMDGPU/R600ISelLowering.h
  lib/Target/AMDGPU/SIISelLowering.cpp
  lib/Target/AMDGPU/SIISelLowering.h
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/ARM/ARMISelLowering.h
  lib/Target/Hexagon/HexagonISelLowering.cpp
  lib/Target/Hexagon/HexagonISelLowering.h
  lib/Target/Mips/Mips16ISelLowering.cpp
  lib/Target/Mips/Mips16ISelLowering.h
  lib/Target/Mips/MipsSEISelLowering.cpp
  lib/Target/Mips/MipsSEISelLowering.h
  lib/Target/PowerPC/PPCISelLowering.cpp
  lib/Target/PowerPC/PPCISelLowering.h
  lib/Target/SystemZ/SystemZISelLowering.cpp
  lib/Target/SystemZ/SystemZISelLowering.h
  lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  lib/Target/WebAssembly/WebAssemblyISelLowering.h
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86ISelLowering.h
  lib/Target/XCore/XCoreISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63075.203809.patch
Type: text/x-patch
Size: 35263 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190610/c41a662f/attachment-0001.bin>


More information about the llvm-commits mailing list