[PATCH] D63024: [LLD] [Driver] Look for -m in response files as well

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 05:21:46 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: tools/lld/lld.cpp:89
+      continue;
+    return isPETarget(*(It + 1));
   }
----------------
I'd avoid function overloading if I can simply give a different name. At first this looked like a recursive function call.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63024/new/

https://reviews.llvm.org/D63024





More information about the llvm-commits mailing list