[PATCH] D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 03:00:25 PDT 2019


grimar added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:375-379
+  if (IsStatic)
+    Link = SN2I.get(".strtab");
+  else
+    SN2I.lookup(".dynstr", Link);
+  SHeader.sh_link = Link;
----------------
jhenderson wrote:
> It looks like this doesn't allow for a custom-specified sh_link field. It might be nice to add that later.
Yes, it will be needed to make a complete test case for https://bugs.llvm.org/show_bug.cgi?id=42215


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63001/new/

https://reviews.llvm.org/D63001





More information about the llvm-commits mailing list