[PATCH] D62964: [llvm-objdump] Include dynamic zero-sized and non-function symbols in disassembly

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 02:53:25 PDT 2019


jhenderson added a comment.

My personal thought is definitely 1), and no need for 3), as long as the error/output makes sense (note that if GNU produces something sensible and doesn't error for 3), we should do the same). I'm in two minds about 2), mostly because we can't be certain that every case we think is unusual applies to every use case out there for downstream users. Ultimately, I'm okay with 2) going either way. I'd plump for matching GNU, but if there's general opinions from others against it, I don't mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964





More information about the llvm-commits mailing list