[PATCH] D63024: [LLD] [Driver] Look for -flavor/-m in response files as well

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 01:05:28 PDT 2019


mstorsjo added a comment.

In D63024#1535891 <https://reviews.llvm.org/D63024#1535891>, @ruiu wrote:

> Do you have to support --rsp-quoting for the use case that you want to support?


Not for my use case, no. But Reid wanted to move all expansion of response files out from the individual linkers here, to avoid reading (and allocating memory for) the (potentially large) response file twice. And in that case, we must handle `--rsp-quoting` perfectly here.

> I believe if you are using MinGW, you are always using Unix-style quoting in response files

At least the default in ELF/DriverUtils.cpp is to use windows quoting style, if the linker binary runs on windows, FWIW.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63024/new/

https://reviews.llvm.org/D63024





More information about the llvm-commits mailing list