[PATCH] D62784: [NFC] Include short string attributes in the "Function Attrs" comment

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

@pcc So I thought about this. I don't think printing all attributes always helps. Testing for a single "Function Attrs" line will be very brittle, the use of multiple check lines will make tests harder to read/write/maintain and the IR output is cluttered. What if we have an output like this one under a flag? It would have all the benefits this patch has and, as you seem to dislike it, it would be on an opt-in basis. Though, I'm still unsure under which circumstance this patch would be worse than the status quo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62784/new/

https://reviews.llvm.org/D62784