[PATCH] D61914: [Support][Test] Time profiler: add regression test

[Puyan Lotfi via llvm-commits]

--target=<triple>

Sent from ProtonMail Mobile

On Fri, Jun 7, 2019 at 2:01 PM, Anton Afanasyev via Phabricator <reviews at reviews.llvm.org> wrote:

> anton-afanasyev marked an inline comment as done.
> anton-afanasyev added a comment.
>
> In D61914#1534508 <https://reviews.llvm.org/D61914#1534508>, @plotfi wrote:
>
>> cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you mean to pass the target explicitly ?
>
> This commit is reverted now. How can I pass the target explicitly?
>
> ================
> Comment at: cfe/trunk/test/Driver/check-time-trace.cpp:1
> +// RUN: %clangxx -ftime-trace %s 2>&1 | grep "Time trace json-file dumped to" \
> +// RUN: | awk '{print $NF}' | xargs cat \
> ----------------
> plotfi wrote:
>> This test should probably have // REQUIRES: shell
> Thanks! I haven't found `REQUIRES: shell` here: `https://llvm.org/docs/CommandGuide/FileCheck.html`. Does this directive mean the target OS must have utils like `awk` and `xargs`?
>
> Repository:
> rL LLVM
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org/D61914/new/
>
> https://reviews.llvm.org/D61914
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190608/b2f8df8f/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: publicKey - puyan at puyan.org - d3f7720045476a2b20d90afa7b39326f9b4bb197.asc
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190608/b2f8df8f/attachment.asc>