[PATCH] D62984: [COFF] Fix /export:foo=bar when bar is a weak alias

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked 5 inline comments as done.
rnk added a comment.

Thanks!



================
Comment at: lld/test/COFF/entry-mangled.test:5
 # RUN: llvm-as -o %t.lto.obj %S/Inputs/entry-mangled.ll
-# RUN: lld-link /out:%t.exe /entry:main %t.lto.obj
+# RUN: lld-link /out:%t.exe /entry:main %t.lto.obj -verbose
 
----------------
mstorsjo wrote:
> Is this `-verbose` needed? I see no checks for its contents.
Oops, it was for debugging.


================
Comment at: llvm/include/llvm/Object/COFFImportFile.h:72-87
+  /// The name of the export as specified in the .def file or on the command
+  /// line, i.e. "foo" in "/EXPORT:foo", and "bar" in "/EXPORT:foo=bar". This
+  /// may lack mangling, such as underscore prefixing and stdcall suffixing.
   std::string Name;
+
+  /// The external, exported name. Only non-empty when export renaming is in
+  /// effect, i.e. "foo" in "/EXPORT:foo=bar".
----------------
ruiu wrote:
> Thank you for doing this!
Hopefully it's correct. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62984/new/

https://reviews.llvm.org/D62984