[PATCH] D63008: LoopDistribute: Add testcase where SCEV wants to insert a runtime check.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/Transforms/LoopDistribute/scev-inserted-runtime-check.ll:5
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-apple-macosx10.10.0"
+
----------------
If possible, remove the target triple; the `x86` target might not be enabled.


================
Comment at: test/Transforms/LoopDistribute/scev-inserted-runtime-check.ll:82
+; CHECK-NEXT:    [[ARRAYIDXA_PLUS_4_LDIST1:%.*]] = getelementptr inbounds i32, i32* [[A]], i64 [[ADD_LDIST1]]
+; CHECK-NEXT:    store i32 [[MULA_LDIST1]], i32* [[ARRAYIDXA_PLUS_4_LDIST1]], align 4, !alias.scope !5
+; CHECK-NEXT:    [[EXITCOND_LDIST1:%.*]] = icmp eq i64 [[ADD_LDIST1]], [[N]]
----------------
`update_test_checks.py` should learn how to abstract MDNodes just like instruction names. In the meantime, maybe remove them manually?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63008/new/

https://reviews.llvm.org/D63008