[PATCH] D62881: [ExecutionEngine] Add UnaryOperator visitor to the interpreter

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/Interpreter/Execution.cpp:73-74
+    default:
+      dbgs() << "Don't know how to handle this unary operator!\n-->" << I;
+      llvm_unreachable(nullptr);
+      break;
----------------
Just move the string into the unreachable? Losing the instruction isn't a huge loss


================
Comment at: llvm/lib/ExecutionEngine/Interpreter/Execution.cpp:84-85
+      } else {
+        dbgs() << "Unhandled type for OP instruction: " << *Ty << "\n";
+        llvm_unreachable(0);
+      }
----------------
Ditto


================
Comment at: llvm/lib/ExecutionEngine/Interpreter/Execution.cpp:92-93
+    default:
+      dbgs() << "Don't know how to handle this unary operator!\n-->" << I;
+      llvm_unreachable(nullptr);
+      break;
----------------
Ditto


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62881/new/

https://reviews.llvm.org/D62881