[PATCH] D62258: [scudo][standalone] Introduce the thread specific data structures

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: lib/scudo/standalone/tsd_exclusive.h:69
+  NOINLINE void initThread(Allocator *Instance, bool MinimalInit) {
+    if (UNLIKELY(!Initialized))
+      initOnce(Instance);
----------------
This is unguarded by the mutex.  I think what we need to do is call `initOnce` unconditionally.


================
Comment at: lib/scudo/standalone/tsd_shared.h:99
+  NOINLINE void initThread(Allocator *Instance) {
+    if (UNLIKELY(!Initialized))
+      initOnce(Instance);
----------------
This is also unguarded by mutex.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62258/new/

https://reviews.llvm.org/D62258