[PATCH] D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M.

Mikhail Maltsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 10:58:16 PDT 2019


miyuki added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:7094
+            "else branch target must be 2 or 4 greater than the branch location");
+    }
+  }
----------------
Missing break


================
Comment at: llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp:5614
+    Inst.addOperand(MCOperand::createReg(ARM::LR));
+    Inst.addOperand(MCOperand::createReg(ARM::LR));
+  case ARM::t2LE:
----------------
Probably missing LLVM_FALLTHROUGH


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62667/new/

https://reviews.llvm.org/D62667





More information about the llvm-commits mailing list