[PATCH] D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:5
+
+## When no `Size` or `Content` is specified for a symbol table section,
+## yaml2obj writes the default content.
----------------
Maybe worth explicitly saying "dynamic symbol table section"


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:98
+    Content: "0123"
+## TODO: .dynstr here is needed to set a proper Link for .dynsym.
+## Otherwize llvm-readobj would report an error.
----------------
As noted above, this deserves a reference to a bug that has been filed.

The comment needs some updates too:
Otherwize (should be Otherwise by the way) llvm-readobj would report -> Without this, llvm-readeobj reports...


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:136
+    Size: 5
+## TODO: .dynstr here is needed to set a proper Link for .dynsym.
+## Otherwize llvm-readobj would report an error.
----------------
Ditto.


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:145
+## than content size. In this case zeroes are added as padding
+## after content specified.
+
----------------
after the specified content


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:177
+    Size: 4
+## TODO: .dynstr here is needed to set a proper Link for .dynsym.
+## Otherwize llvm-readobj would report an error.
----------------
See above.


================
Comment at: test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml:217
+    Size: 2
+## TODO: .dynstr here is needed to set a proper Link for .dynsym.
+## Otherwize llvm-readobj would report an error.
----------------
See above.


================
Comment at: test/tools/yaml2obj/section-size-content.yaml:105
+## than content size. In this case zeroes are added as padding
+## after content specified.
+
----------------
after content specified -> after the specified content


================
Comment at: test/tools/yaml2obj/strtab-implicit-sections-size-content.yaml:98
+## when size is greater than content size. In this case zeroes are
+## added as padding after content specified.
+
----------------
Same as above.


================
Comment at: test/tools/yaml2obj/symtab-implicit-sections-size-content.yaml:127
+## than content size. In this case zeroes are added as padding
+## after content specified.
+
----------------
See above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62957/new/

https://reviews.llvm.org/D62957