[PATCH] D62995: [IntrinsicEmitter] Extend argument overloading with forward references.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 06:11:17 PDT 2019


arsenm added inline comments.


================
Comment at: include/llvm/IR/Intrinsics.td:1185-1202
+def int_experimental_dummy_backward : Intrinsic<[llvm_anyvector_ty],
+                                                [llvm_anyvector_ty,
+                                                 LLVMVectorOfAnyPointersToElt<0>,
+                                                 LLVMVectorOfAnyPointersToElt<1>,
+                                                 LLVMVectorElementType<0>], []>;
+
+def int_experimental_dummy_forward : Intrinsic<[LLVMVectorOfAnyPointersToElt<0>],
----------------
These should just go to a TableGen test file instead of defining a real intrinsic


================
Comment at: lib/IR/Function.cpp:1195
       if (D.getArgumentNumber() >= ArgTys.size())
-        return true;
+        return IsDeferredCheck ? true : DeferCheck(Ty);
       VectorType * ReferenceType =
----------------
IsDeferredCheck || DeferCheck(Ty)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62995/new/

https://reviews.llvm.org/D62995





More information about the llvm-commits mailing list