[PATCH] D62984: [COFF] Fix /export:foo=bar when bar is a weak alias

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

Looks good and thought through. I had a few nits though.



================
Comment at: lld/COFF/SymbolTable.cpp:475
 
-StringRef SymbolTable::findByPrefix(StringRef Prefix) {
+// Return all symbols matching '.?${Prefix}'.
+std::vector<Symbol *> SymbolTable::getSymsWithPrefix(StringRef Prefix) {
----------------
This regex is a little misleading/incomplete, as it can also match by skipping the first char of Prefix. (I guess that can't be expressed in regex syntax easily...)


================
Comment at: lld/test/COFF/entry-mangled.test:5
 # RUN: llvm-as -o %t.lto.obj %S/Inputs/entry-mangled.ll
-# RUN: lld-link /out:%t.exe /entry:main %t.lto.obj
+# RUN: lld-link /out:%t.exe /entry:main %t.lto.obj -verbose
 
----------------
Is this `-verbose` needed? I see no checks for its contents.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62984/new/

https://reviews.llvm.org/D62984