[PATCH] D60772: [AMDGPU] Add optional bounds checking for scratch accesses

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D60772#1501198 <https://reviews.llvm.org/D60772#1501198>, @nhaehnle wrote:

> In D60772#1470073 <https://reviews.llvm.org/D60772#1470073>, @arsenm wrote:
>
> > I don't understand the problem being solved here. Who/what is this intended to benefit? An out of bounds access is going to be undefined.
>
>
> Graphics APIs have "robust (buffer) access" settings in which out of bounds accesses must be guaranteed not to crash the program.


And this is allowed to be set for stack objects?



================
Comment at: lib/Target/AMDGPU/SIFixScratchSize.cpp:71
+        if (Src.isSymbol()) {
+          if (strcmp(Src.getSymbolName(), SIScratchSizeSymbol) == 0) {
+            LLVM_DEBUG(dbgs() << "Fixing: " << MI << "\n");
----------------
No c string functions


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60772/new/

https://reviews.llvm.org/D60772