[PATCH] D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files.

[Mike Edwards via Phabricator via llvm-commits]

sqlbyme added a comment.

In D62353#1516323 <https://reviews.llvm.org/D62353#1516323>, @beanz wrote:

> In D62353#1516322 <https://reviews.llvm.org/D62353#1516322>, @hintonda wrote:
>
> > Btw, where would you want to put them?
>
>
> Pre-monorepo, it would depend on what the bot is building, but with the mono-repo we could just create a new top-level directory to contain them all. Name each file to match the bot config it runs.


Beanz if you can send me an example of what you think the directory layout should look like I'll try to implement one of these on the mono-repo and get a test bot running.  Then folks could have an example to look at.

>> Perhaps if they existed, it might be easier to bot owners to use them.
> 
> I think bot owners need to create and maintain them. Today bot owners control what flags they pass to CMake and we shouldn't change that.

+1 for having bot owners be responsible for making this change.  Though I feel like we could do some work behind the scenes to make it easier for them to move to this convention.  Also, we probably
should have a discussion on the list about making this the new standard for setting up bots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62353/new/

https://reviews.llvm.org/D62353