[PATCH] D62706: [llvm-lipo] Add docs for llvm-lipo

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 16:29:34 PDT 2019


alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: docs/CommandGuide/llvm-lipo.rst:28
+
+  Verify that the specified architectures are present in the input file.
+
----------------
mtrent wrote:
> Verify that the specified architecture is present by doing what? Best to call out the command's exit status here.  
> 
> Is it obvious what "architecture" means here? How would you describe that to someone?
> 
> The -verify_arch command only works on a single file (the Apple man page suggests otherwise, but AFAICT the code has never supported that). Do you need to mention that here? 
 >Is it obvious what "architecture" means here?
no, it's not, honestly, I don't have a good explanation appropriate for docs other than "supported  architecture name" with some popular examples, would you like me to add these bits here ? 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62706/new/

https://reviews.llvm.org/D62706





More information about the llvm-commits mailing list