[PATCH] D62985: AMDGPU: Insert skip branches over return blocks

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 14:53:40 PDT 2019


arsenm created this revision.
arsenm added reviewers: rampitec, nhaehnle.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, wdng, jvesely, kzhuravl.

SIInsertSkips really doesn't understand the control flow, and makes
very stupid assumptions about the block layout. This was able to get
away with not skipping return blocks, since usually after
structurization there is only one placed at the end of the
function. Tail duplication can break this assumption.


https://reviews.llvm.org/D62985

Files:
  lib/Target/AMDGPU/SIInsertSkips.cpp
  lib/Target/AMDGPU/SIInstrInfo.cpp
  test/CodeGen/AMDGPU/skip-branch-taildup-ret.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62985.203456.patch
Type: text/x-patch
Size: 11467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190606/83b62cb3/attachment.bin>


More information about the llvm-commits mailing list