[PATCH] D62718: [llvm-objcopy] Change handling of output file permissions

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 12:06:06 PDT 2019


abrachet updated this revision to Diff 203407.
abrachet retitled this revision from "[llvm-objcopy] Change output file permissions to be the same as the input file" to "[llvm-objcopy] Change handling of output file permissions".
abrachet edited the summary of this revision.
abrachet added a comment.

Removes checks that both input and output files are not stdin and stdout when --preserve-date (to be added in a seperate patch). Significantly simplifies the changing of permissions, now done on opening the file which will also respect the umask.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62718/new/

https://reviews.llvm.org/D62718

Files:
  llvm/test/tools/llvm-objcopy/ELF/execute-permissions.test
  llvm/test/tools/llvm-objcopy/ELF/respect-umask.test
  llvm/tools/llvm-objcopy/Buffer.cpp
  llvm/tools/llvm-objcopy/Buffer.h
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62718.203407.patch
Type: text/x-patch
Size: 5462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190606/cf4df9ec/attachment.bin>


More information about the llvm-commits mailing list