[PATCH] D60386: FileCheck [6/12]: Introduce numeric variable definition

Thu Jun 6 06:14:38 PDT 2019

jhenderson accepted this revision.
jhenderson added a comment.

In D60386#1531177 <https://reviews.llvm.org/D60386#1531177>, @thopre wrote:

> In D60386#1531043 <https://reviews.llvm.org/D60386#1531043>, @jhenderson wrote:
>
> > Looks good except for one thing: missing unit tests for  `parseNumericVariableUse`?
>
>
> This is a private method so I've moved the tests to ParseExpr which tests parseNumericSubstitutionBlock which calls into parseBinop (also private) which calls into parseNumericVariableUse.

Oh, my bad, I checked before making that comment, and thought it was public. Must have misread the code. LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60386/new/

https://reviews.llvm.org/D60386