[PATCH] D62604: [CodeGen] Generic Hardware Loop Support

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:451
 
+  /// Attributes of a target dependent hardware loop. Here, the term 'element'
+  /// describes the work performed by an IR loop that has not been vectorized
----------------
I am not sure we need speak about elements in vectorised or non-vectorised loops here, see comment below.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:462
+    IntegerType *CountType    = nullptr;
+    Value *NumElements        = nullptr;  // The maximum number of elements
+                                          // processed in the loop body.
----------------
Can we now just call this the loop decrement?


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:466
+                                          // another hardware loop.
+    bool CounterInReg         = false;    // Should be loop counter be updated
+                                          // in the loop via a phi?
----------------
Nit: "Should be loop". Spell error? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62604/new/

https://reviews.llvm.org/D62604