[PATCH] D61185: [RISCV] Add CostModel GEP tests

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 02:50:14 PDT 2019


luismarques marked 2 inline comments as done.
luismarques added inline comments.


================
Comment at: test/Analysis/CostModel/RISCV/gep.ll:18
+; RVI-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: ret void
+;
+  %a0 = getelementptr inbounds i8, i8* %a, i32 0
----------------
asb wrote:
> Nit: I think these empty comment lines are unwanted and an artifact of when there were two different check prefixes
As discussed with @asb in person, and for future reference, update_analyze_test_checks.py does add the empty comment lines, while update_llc_test_checks.py does not.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61185/new/

https://reviews.llvm.org/D61185





More information about the llvm-commits mailing list