[PATCH] D62604: [CodeGen] Generic Hardware Loop Support

Thu Jun 6 02:14:37 PDT 2019

samparker marked an inline comment as done.
samparker added inline comments.

================
Comment at: lib/Analysis/TargetTransformInfo.cpp:135
+  LLVMContext &C = L->getHeader()->getContext();
+  CountType = Type::getInt32Ty(C);
+  NumElements = ConstantInt::get(CountType, 1);
----------------
hfinkel wrote:
> I'm unclear on the rationale for this default initialization. Is there really value here, or should we just set these to nullptr or similar?
I mainly did it so that we don't need a supported target to run some basic tests. But really I guess I can just make them cli options, as I've done for other parts of testing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62604/new/

https://reviews.llvm.org/D62604