[PATCH] D62900: [RISCV] Support Bit-Preserving FP in F/D Extensions

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 21:58:16 PDT 2019


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

With the addition of nounwind to the tests, this looks good to me. Thanks!



================
Comment at: llvm/test/CodeGen/RISCV/float-bit-preserving-dagcombines.ll:17
+
+define float @bitcast_and(float %a1, float %a2) {
+; RV32F-LABEL: bitcast_and:
----------------
Please add the `nounwind` attribute to all of these functions, so this tests won't be affected when call frame info directives are emitted (update_llc_test_checks.py doesn't strip them out).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62900/new/

https://reviews.llvm.org/D62900





More information about the llvm-commits mailing list