[PATCH] D62766: [Attributor] Deduce "nosync" function attribute.

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

Inline comments are now not in original order, so I'll reply here.

> I think the`!` in front of ICS is a problem. Did you run this?

Yes.

> Why is it sufficient that one ordering is "weak enough"? Don't we have to test both? Either way, we need a comment to explain what is happening here.

My thinking is that if either one of them 'weak enough', than "no-sync" is no longer possible since at any point it can be one of the orderings. If you disagree, I can change and require both.

> Indention. And maybe add a few more words here ;)

I updated the function comment, hope thats enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62766/new/

https://reviews.llvm.org/D62766