[PATCH] D51701: ValueTracking: Report fast math flags for fcmp/select

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 09:55:02 PDT 2019


spatel added a comment.

In D51701#1414272 <https://reviews.llvm.org/D51701#1414272>, @spatel wrote:

> Is the root problem that we don't have FMF on any FP select? We discussed that in:
>  https://bugs.llvm.org/show_bug.cgi?id=38086
>
> If that's correct, I think we should make that change instead of making matchSelectPattern more complicated.


rL361401 <https://reviews.llvm.org/rL361401> - enabled FMF for select-of-FP, so I'm not sure where we stand on this patch. I'm also proposing to canonicalize to minnum/maxnum intrinsics from fcmp+select in D62414 <https://reviews.llvm.org/D62414>, so that might remove some of the motivation for this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51701/new/

https://reviews.llvm.org/D51701





More information about the llvm-commits mailing list