[PATCH] D62909: [MSAN] Add unary FNeg visitor to the MemorySanitizer

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 08:15:49 PDT 2019


cameron.mcinally created this revision.
cameron.mcinally added reviewers: spatel, craig.topper, andrew.w.kaylor, arsenm, kpn, eugenis.
Herald added subscribers: llvm-commits, hiraditya, wdng.
Herald added a project: LLVM.

I'm not familiar with this pass, so a thorough review is appreciated.

Note that I was not able to find existing tests for the binary FP operators. It seems as if they're just pass-throughs since they don't touch memory. Or did I miss something?


Repository:
  rL LLVM

https://reviews.llvm.org/D62909

Files:
  llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp


Index: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
===================================================================
--- llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
+++ llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
@@ -2110,6 +2110,8 @@
     SC.Done(&I);
   }
 
+  void visitFNeg(UnaryOperator &I) { handleShadowOr(I); }
+
   // Handle multiplication by constant.
   //
   // Handle a special case of multiplication by constant that may have one or


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62909.203161.patch
Type: text/x-patch
Size: 485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190605/8993b29a/attachment.bin>


More information about the llvm-commits mailing list