[PATCH] D62898: [llvm-objcopy] - Emit error and don't crash if program header reaches past end of file.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/invalid-p_filesz-p_offset.test:24
+
+## A similar case, but now p_offset property of program header is too large.
+
----------------
now -> now the
of program -> of the program


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:1110
+            " and file size 0x" + Twine::utohexstr(Phdr.p_filesz) +
+            " is malformed");
+
----------------
Maybe rather than "is malformed" it might be better to say "goes past the end of the file" or something similar.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62898/new/

https://reviews.llvm.org/D62898