[PATCH] D62823: [AIX] Implement call lowering with parameters could pass onto GPRs

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix_gpr_param.ll:36
+; 64BIT: ADJCALLSTACKUP 112, 0, implicit-def dead $r1, implicit $r1
+  call void @test_chars(i8 signext 97, i8 signext 97, i8 signext 97, i8 signext 97)
+
----------------
Please test with some use of `zeroext` and some values where it would matter.
```
  call void @test_chars(i8 signext 97, i8 zeroext -31, i8 zeroext 97, i8 signext -31)
```


================
Comment at: llvm/test/CodeGen/PowerPC/aix_gpr_param.ll:72
+; 64BIT: ADJCALLSTACKUP 112, 0, implicit-def dead $r1, implicit $r1
+  call void @test_ints(i32 1, i32 1, i32 1, i32 1, i32 1, i32 1, i32 1, i32 1)
+
----------------
Similarly (although the front-end does not seem to produce this for AIX yet),
```
  call void @test_ints(i32 signext 1, i32 zeroext 1, i32 zeroext 2147483648, i32 signext -2147483648, i32 signext 1, i32 signext 1, i32 signext 1, i32 signext 1)
```


================
Comment at: llvm/test/CodeGen/PowerPC/aix_gpr_param.ll:114
+
+declare void @test_chars(i8 signext, i8 signext, i8 signext, i8 signext)
+
----------------
```
declare void @test_chars(i8 signext, i8 zeroext, i8 zeroext, i8 signext)
```


================
Comment at: llvm/test/CodeGen/PowerPC/aix_gpr_param.ll:118
+
+declare void @test_ints(i32, i32, i32, i32, i32, i32, i32, i32)
+
----------------
```
declare void @test_ints(i32 signext, i32 zeroext, i32 zeroext, i32 signext, i32 signext, i32 signext, i32 signext, i32 signext)
```

Have a separate function if you are concerned that this is more 64-bit specific than not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62823/new/

https://reviews.llvm.org/D62823